Avoid crashes with deep threads #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version inadvertently turned collapsing into an all-or-nothing behavior.
Resets the standard message collapsing value when a depth boundary is encountered, makes the UI work in all combinations, and fixes some some issues pointed out by the linter.
Apparently, the combination :not(collapsible).expanded is not meant to be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the Euphoria-side thread depth limit has fallen, React still starts behaving badly when too deeply nested messages appear, leading to looping crashes in certain situations (e.g.
showAllRepliesenabled or a very deep thread the user posted in), potentially rendering Euphoria entirely unusable.This avoids the problem by forcing a collapse (disregarding
showAllReplies) at a (large) depth as a “safety net” against the crashes.The user can still risk seeing the remainder of the thread by expanding the collapsed reply section.