fix(mcp): reject non-finite or non-positive connect timeouts#679
Merged
evalstate merged 1 commit intoevalstate:mainfrom Feb 11, 2026
Merged
Conversation
Owner
|
LOL, you were quick on that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate
/mcp connect --timeoutvalues to reject non-finite and non-positive numbers.Previously
parse_connect_inputacceptedfloat(...)without finiteness checks, which allowed values likenanandinf.Changes
src/fast_agent/commands/handlers/mcp_runtime.pyfloat, require:math.isfinite(timeout_seconds)timeout_seconds > 0ValueErrorwhen invalid.tests/unit/fast_agent/commands/test_mcp_runtime_handlers.pynan,inf,-inf,0, and-1.Validation
uv run pytest tests/unit/fast_agent/commands/test_mcp_runtime_handlers.py -quv run ruff check src/fast_agent/commands/handlers/mcp_runtime.py tests/unit/fast_agent/commands/test_mcp_runtime_handlers.py