Skip to content

Restructure pre-release and e2e tests, and standardize internal namespace to @repo #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lfarrel6 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Restructure pre-release and e2e tests, and standardize internal namespace to @repo #627

lfarrel6 wants to merge 4 commits into from

Conversation

@lfarrel6
Copy link
Member

@lfarrel6 lfarrel6 commented Mar 31, 2025 •
edited
Loading

Why

We used a variety of namespaces for internal packages in this repo which was quite messy (reusing public facing @evervault, using @ev which doesn't exist but could, and some without a namespace entirely).

How

  • Move to using @repo to denote a private internal project
  • Split up e2e tests and pre-release harnesses to make it easier to orchestrate work in CI.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 00d73f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lfarrel6 lfarrel6 marked this pull request as ready for review March 31, 2025 16:17
@lfarrel6 lfarrel6 requested a review from a team as a code owner March 31, 2025 16:17
@lfarrel6 lfarrel6 force-pushed the liam/etr-3171-isolate-environments-in-the-js-repo branch from 86bb540 to c804957 Compare April 1, 2025 09:40
@lfarrel6 lfarrel6 marked this pull request as draft April 3, 2025 16:17
@lfarrel6 lfarrel6 force-pushed the liam/etr-3171-isolate-environments-in-the-js-repo branch from e20547a to 09000f9 Compare April 3, 2025 16:19
@socket-security
Copy link

socket-security bot commented Apr 3, 2025 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@lfarrel6 lfarrel6 changed the title Isolate environments in the js repo Restructure pre-release and e2e tests, and standardize internal namespace to @repo Apr 3, 2025
@lfarrel6 lfarrel6 marked this pull request as ready for review April 3, 2025 16:28
thomascullen
thomascullen approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@thomascullen thomascullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@lfarrel6 lfarrel6 force-pushed the liam/etr-3171-isolate-environments-in-the-js-repo branch from 09000f9 to 60129a5 Compare May 27, 2025 11:17
thomascullen
thomascullen approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@thomascullen thomascullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomascullen thomascullen thomascullen approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lfarrel6 @thomascullen