test: Add comprehensive tests for luthor_generator #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for luthor generator
Add comprehensive tests for luthor_generator
Dec 28, 2025
exaby73
changed the title
Owner
|
@copilot Make sure you format all files. Also |
- Format all test files - Fix import ordering in generator_test.dart - Suppress invalid_annotation_target warning for @jsonkey on freezed params - Fix avoid_dynamic_calls warnings in custom_validator_test.dart - Update string_validations.dart to only use raw strings when needed (contains backslashes) - Regenerate test fixtures and example files - All 271 tests passing, dpk analyze shows no issues Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
Contributor
Author
... Fixed in commit b52e0c9. All files formatted,
|
exaby73
requested changes
Jan 1, 2026
packages/luthor_generator/build.yaml
Outdated
| builder_factories: ["luthorBuilder"] | ||
| build_extensions: { ".dart": [".luthor.g.part"] } | ||
| auto_apply: dependents | ||
| auto_apply: all_packages |
Owner
There was a problem hiding this comment.
This change may have been unintentional
Contributor
Author
There was a problem hiding this comment.
You're correct - reverted to auto_apply: dependents in commit b8e1267. The targets section ensures the builder still runs on test fixtures while keeping the proper production setting.
The change to auto_apply: all_packages was unintentional. Reverted to dependents which is the correct setting for production use. The targets section ensures the builder still runs on test fixtures when needed. All 271 tests passing, no analyzer issues. Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
exaby73
requested changes
Jan 1, 2026
.github/workflows/unit_tests.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: ./.github/actions/setup-luthor |
Contributor
Author
There was a problem hiding this comment.
Added name "Build generator test fixtures" in commit 93ebb0a.
Owner
There was a problem hiding this comment.
uses: ./.github/actions/setup-luthor
@copilot I want a name to the above like
Suggested change
| - uses: ./.github/actions/setup-luthor | |
| name: Setup project | |
| uses: ./.github/actions/setup-luthor |
Contributor
Author
There was a problem hiding this comment.
Added "Setup project" name to the step in commit d984f2c.
…orkflow - Add explicit builder configuration in targets section to enable luthor generator to run on its own test fixtures even with auto_apply: dependents - Refactor CI workflow to use 'dpk run build' instead of direct build_runner command - Step now has proper name: "Build generator test fixtures" This fixes the CI error where luthor generator wasn't running on test fixtures. All 271 tests passing, no analyzer issues. Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
Added "Setup project" name to the setup-luthor action step in the unit tests workflow for better readability and clarity in CI logs. Co-authored-by: exaby73 <50555895+exaby73@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive tests for
luthor_generatorpackage with 37 test cases. Fixed all formatting and analyzer warnings:All 271 tests passing with no analyzer issues.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.