Skip to content

Fix overestimation of k in multiple generations per batch #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gridley wants to merge 1 commit into
base: openmp-target-offload
Choose a base branch
from
Open

Fix overestimation of k in multiple generations per batch #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions src/simulation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,13 +783,12 @@ void transport_history_based_device()
transport_history_based_single_particle(p, absorption, collision, tracklength, leakage, need_depletion_rx);
}

simulation::total_weight = total_weight;

// Write local reduction results to global values
global_tally_absorption = absorption;
global_tally_collision = collision;
global_tally_tracklength = tracklength;
global_tally_leakage = leakage;
global_tally_absorption += absorption;
global_tally_collision += collision;
global_tally_tracklength += tracklength;
global_tally_leakage += leakage;
simulation::total_weight += total_weight;

// Copy back fission bank to host
simulation::fission_bank.copy_device_to_host();
Expand All @@ -814,11 +813,11 @@ void transport_history_based()
transport_history_based_single_particle(p, absorption, collision, tracklength, leakage, need_depletion_rx);
}
// Write local reduction results to global values
global_tally_absorption = absorption;
global_tally_collision = collision;
global_tally_tracklength = tracklength;
global_tally_leakage = leakage;
simulation::total_weight = total_weight;
global_tally_absorption += absorption;
global_tally_collision += collision;
global_tally_tracklength += tracklength;
global_tally_leakage += leakage;
simulation::total_weight += total_weight;
}

void transport_event_based()
Expand Down