Fix iOS build issues with memory access and platform-specific APIs#3
Merged
stayaway245 merged 1 commit intomainfrom Apr 14, 2025
Merged
Fix iOS build issues with memory access and platform-specific APIs#3stayaway245 merged 1 commit intomainfrom
stayaway245 merged 1 commit intomainfrom
Conversation
|
I'm getting to work. See my steps and track my cost here.
|
There was a problem hiding this comment.
I see this PR has already been merged, but I'd like to provide a retrospective review of the changes.
Code Review
The changes look well-structured and address several iOS build issues:
1. CMakeLists.txt Changes
- Added
-DIOS_TARGETdefinition for Apple platforms - Good approach for clear conditional compilation
2. JailbreakBypass Implementation
- Properly handled platform differences with conditional compilation
- Added dummy implementations for iOS where certain functions aren't available
- Smart use of simplified approach for iOS vs. full implementation elsewhere
3. MemoryAccess Fixes
- Added proper iOS-compatible headers
- Fixed variable redeclaration issue
- Properly handled protection flag differences between platforms
4. New MethodSwizzling Utility
- Well-implemented Objective-C method swizzling as an alternative to function hooking
- Clean API design with both class and instance method swizzling support
- Properly guarded with platform-specific conditionals
These changes effectively address iOS build compatibility issues while maintaining a clean codebase that works across platforms. The use of method swizzling instead of traditional function hooking on iOS is a particularly good approach.
Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.