Show URL of currently selected bookmark #16

.devcontainer/init-container.bash

@@ -2,3 +2,5 @@
 set -xe
 npm clean-install
 pre-commit install
+npx playwright install-deps
+npx playwright install

.github/workflows/main.yml

@@ -3,11 +3,36 @@ name: CI
 
 on:
   push:
-    tags: ["v*"]
+  pull_request:
 
 jobs:
+  unit-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: "16"
+      - run: npm clean-install
+      - run: npm run test-unit
+  e2e-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: "16"
+      - run: npm clean-install
+      - run: npx playwright install-deps
+      - run: npm run test-e2e
   build:
     runs-on: ubuntu-latest
+    if: >
+      github.event_name == 'push' &&
+      startsWith(github.event.ref, 'refs/tags')
+    needs:
+      - unit-tests
+      - e2e-tests
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3

.gitignore

@@ -2,3 +2,4 @@
 /build
 /dist
 /unpackaged
+coverage

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.2.3
+
+- Allow error messages to be closed
+
 # 1.2.2
 
 - Fix default icon for Chromium based browsers (edge, chrome, ...)

Makefile

@@ -14,14 +14,11 @@ mozilla: pages bundled_docs
 icons:
 	mkdir -p unpackaged/chrome/assets
 	inkscape -w 48 -h 48 assets/icon.svg \
-		-o unpackaged/chrome/assets/icon48.png \
-		2>/dev/null
+		-o unpackaged/chrome/assets/icon48.png
 	inkscape -w 96 -h 96 assets/icon.svg \
-		-o unpackaged/chrome/assets/icon96.png \
-		2>/dev/null
+		-o unpackaged/chrome/assets/icon96.png
 	inkscape -w 128 -h 128 assets/icon.svg \
-		-o unpackaged/chrome/assets/icon128.png \
-		2>/dev/null
+		-o unpackaged/chrome/assets/icon128.png
 
 chrome: pages bundled_docs icons
 	cp -r build/* unpackaged/chrome/

TODO

@@ -1,7 +1,7 @@
-- Add a text-search for bookmarks
-- Allow sources to be enabled/disabled
-- Add default tags per source
-- Replace arrays with sets where possible
-- Add a name to each source
 - Deduplicate bookmarks (if more than one source has the same bookmark, it is added with duplicates)
+- New Source Settings
+    - Allow sources to be enabled/disabled
+    - Add default tags per source
+    - Add a name to each source
+- Replace arrays with sets where possible
 - Is "postcss" still needed?

demo/demo.ts

@@ -17,6 +17,9 @@ function initSettingsUI() {
   let settingsElementV2 = document.getElementById(
     "SettingsV2"
   ) as SettingsElement;
+  let settingsElementV3 = document.getElementById(
+    "SettingsV3"
+  ) as SettingsElement;
   settingsElementV2.settings = JSON.stringify({
     remoteUrls: [
       "https://raw.githubusercontent.com/exhuma/dotfiles/master/bookmarks.json",
@@ -25,6 +28,10 @@ function initSettingsUI() {
     enableBrowserBookmarks: true,
     version: 2,
   });
+  settingsElementV3.settings = JSON.stringify({
+    sources: [],
+    version: 3,
+  });
   settingsElementV2.addEventListener("change", (event) => {
     let evt = event as CustomEvent;
     console.log(JSON.parse(evt.detail["settings"]));

demo/index.html

@@ -62,6 +62,16 @@
       #Content {
         flex-grow: 1;
       }
+
+      #Settings {
+        margin: 2em;
+      }
+
+      H1 {
+        color: black;
+        border-bottom: 1px solid black;
+        margin-bottom: 1em;
+      }
     </style>
   </head>
 
@@ -175,6 +185,18 @@ <h1>Settings V1</h1>
             <h1>Settings V2</h1>
             <sh-settings id="SettingsV2" settings="{}"></sh-settings>
           </div>
+          <div
+            style="
+              float: left;
+              padding: 1rem;
+              width: 400px;
+              height: 500px;
+              border: 1px solid black;
+            "
+          >
+            <h1>Settings V3</h1>
+            <sh-settings id="SettingsV3" settings="{}"></sh-settings>
+          </div>
         </div>
       </div>
     </div>

docs/development.md

@@ -7,7 +7,7 @@ but provides a reproducible build environment with all required system
 dependencies. When working with VS-Code (including the
 `ms-vscode-remote.vscode-remote-extensionpack` extension) the development
 container can be built manually by opening the command-pallette (CTRL-SHIFT-P)
-and selecting `Remote-Containers: Rebuild Container` command. This can also be
+and selecting `Dev-Containers: Rebuild Container` command. This can also be
 used any time something in the container has changed.
 
 1. Clone the Repository
@@ -19,11 +19,11 @@ used any time something in the container has changed.
 
 1. Build
 
-   - With VS-Code using the "Remote Containers" extension
+   - With VS-Code using the "Remote Development" extension
 
      - Build the development container
 
-       Select "Remote-Containers: Rebuild Container" from the command-pallette
+       Select "Dev Containers: Rebuild Container" from the command-pallette
        (CTRL-SHIFT-P)
 
      - Build the extension