Draft
Conversation
Senna46
reviewed
Nov 28, 2023
Contributor
Senna46
left a comment
Senna46
left a comment
There was a problem hiding this comment.
Commented on the points of concern. If it is OK, I will fix it.
proto/ununifi/irs/tx.proto
Outdated
| uint64 tranche_id = 2; | ||
| TrancheType tranche_type = 3; | ||
| cosmos.base.v1beta1.Coin token = 4 [(gogoproto.nullable) = false]; // Underlying token to be spent | ||
| cosmos.base.v1beta1.Coin required_yt = 5 |
Contributor
There was a problem hiding this comment.
This is the argument required for Withdraw. Not required for Deposit
For Withdraw
token and required_yt are difficult to understand
I think the array is still better. And the variable name amount is better.
proto/ununifi/irs/tx.proto
Outdated
|
|
||
| string sender = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; | ||
| uint64 tranche_id = 2; | ||
| TrancheType tranche_type = 3; |
Contributor
There was a problem hiding this comment.
Withdraw does not require this enum. If there is an array Amount, we can handle the behavior of Withdraw.
| string name = 3; | ||
| string description = 4; | ||
| uint64 max_maturity = 5; // e.g. 180 days | ||
| uint64 cycle = 6; // e.g. 90 days |
Contributor
There was a problem hiding this comment.
I think seconds are better. same as gov voting_period
x/irs/keeper/abci.go
Outdated
| } | ||
| vaults := k.GetAllVault(ctx) | ||
| for _, vault := range vaults { | ||
| if int64((vault.Cycle*86400)+vault.LastTrancheTime) < ctx.BlockTime().Unix() { |
* feat: irs test * feat: vault & tranche * feat; register irs module * feat: tranche * feat: stripping error * fix: maturity * feat: wip test * fix: mint perm * fix: update pool info * fix: amm & test * chore: totalshare * revert changes for amm.go discussed --------- Co-authored-by: Senna46 <29295263+Senna46@users.noreply.github.com> Co-authored-by: jununifi <jun.ununifi@outlook.com>
DeputyDepositToTranche via IBC-hooks
… liquidity implementation
Merge Develop changes into irs_module
fix: pt mint conflict
fix: stATOM/ATOM rate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.