Open
Conversation
jununifi
reviewed
Nov 1, 2023
| use crate::msgs::{ExecuteMsg, InstantiateMsg, MigrateMsg, QueryMsg}; | ||
| use crate::query::bonus_windows::query_bonus_windows; | ||
| use crate::query::distribution_amount::query_distribution_amount; | ||
| // use crate::query::distribution_amount::query_distribution_amount; |
Contributor
There was a problem hiding this comment.
Could remove this commented code
jununifi
reviewed
Nov 1, 2023
| to_binary(&query_distribution_amount(deps, bonus_window_id)?) | ||
| } | ||
| } => to_binary(&query_vault_share_staking(deps, bonus_window_id, vault_id, address)?), | ||
| // QueryMsg::DistributionAmount { bonus_window_id } => { |
Contributor
There was a problem hiding this comment.
Is this PR ready for review? I see some commented codebase
jununifi
reviewed
Nov 1, 2023
| deps | ||
| } | ||
|
|
||
| // #[test] |
jununifi
reviewed
Nov 1, 2023
| query_bonus_window(deps.as_ref(), 0).unwrap_err(); | ||
|
|
||
| let voted_vault = query_voted_vaults(deps.as_ref(), 0).unwrap_err(); | ||
| // assert_eq!(voted_vault.len(), 2); |
Contributor
There was a problem hiding this comment.
This check has been disabled for some reason
jununifi
reviewed
Nov 1, 2023
| // todo!() | ||
| // // let resp = DistributionAmountResp {}; | ||
| // // Ok(resp) | ||
| // } |
Contributor
There was a problem hiding this comment.
whole code seems to be commented for this file
jununifi
reviewed
Nov 1, 2023
| @@ -1,5 +1,5 @@ | |||
| pub mod bonus_windows; | |||
| pub mod distribution_amount; | |||
| // pub mod distribution_amount; | |||
Contributor
There was a problem hiding this comment.
Can you remoce this code if not used?
jununifi
reviewed
Nov 1, 2023
| // bonus_window_id: u64, | ||
| // for_all: Vec<Distribution>, | ||
| // for_winners: Vec<Distribution>, | ||
| // } |
Contributor
There was a problem hiding this comment.
Can you remove this one as well?
jununifi
reviewed
Nov 1, 2023
| }); | ||
| send_msgs.push(send_msg); | ||
| } | ||
| Ok(send_msgs) |
Contributor
There was a problem hiding this comment.
Is it fine to distribute the reward on a single message? I think it would overflow the block gas limit if the number of users are more than 1000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #64