Skip to content

elementary_test: Fix division by zero #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
felipealmeida wants to merge 1 commit into
base: devs/expertise/native-windows
Choose a base branch
from
Open

elementary_test: Fix division by zero #449

felipealmeida wants to merge 1 commit into from

Conversation

@felipealmeida
Copy link
Member

@felipealmeida felipealmeida commented Sep 15, 2020

Fixes #446

joaoantoniocardoso
joaoantoniocardoso approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@joaoantoniocardoso joaoantoniocardoso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this patch does fixes the error of crash when no numbers are set, the Windows crash when clicking Genlist Tree remains, so this patch is in fact interesting but it doesn't solve #446.

edit: It does fixes #446, except that when you abuse setting a big tree like 100, it crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

elementary_tests: Genlist Tree button crashes, closing everything.

3 participants

@felipealmeida @joaoantoniocardoso