win32: Fix wait win32 objects with 64 or more objects #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was using MsgWaitForMultipleObjects in threads where there were no Windows, and the main thread used WaitForMultipleObjects, which caused timeout even if input messages had to be handled. Also, the quit thread also waited for all threads, which meant waiting for timeout. The fix consisted in using MsgWaitForMultipleObjects in the main thread instead and creating a quit event that made WaitForMultipleObjects return when a signalled event or message was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was using MsgWaitForMultipleObjects in threads where there were
no Windows, and the main thread used WaitForMultipleObjects, which
caused timeout even if input messages had to be handled.
Also, the quit thread also waited for all threads, which meant waiting
for timeout.
The fix consisted in using MsgWaitForMultipleObjects in the main
thread instead and creating a quit event that made
WaitForMultipleObjects return when a signalled event or message was found.