win32: Enable dotnet on windows #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoantoniocardoso
changed the title
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
from
98234f5 to
f24b9df
Compare
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
2 times, most recently
from
4496b08 to
f03c05e
Compare
A variable in .eo with the type (u)long was resulting in an (u)int type in the generated build/src/tests/efl_mono/dummy_test_object.eo.cs Sincerly I don't know how it is working even with the lines commented. Still, there is some issue with (u)llong typed variables that are being converted to (u)long and being truncated with 32bits.
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
from
f03c05e to
0bf6e03
Compare
Summary: OSX libs end with `.dylib`, so it made failed to load libs, for instance dl name is `dl.dylib` making it unable to load as it was before (`libdl.so`). Test Plan: Compare with master and note that this diff is able to fail on tests, and not about importing libs. - Configure as especified by Enlightenment man page + `-Dbindigns=mono -Ddotnet=true`: ``` meson -Dsystemd=false -Dv4l2=false -Davahi=false -Deeze=false -Dx11=false -Dopengl=full -Dcocoa=true -Dnls=false -Demotion-loaders-disabler=gstreamer1,libvlc,xine -Decore-imf-loaders-disabler=scim,ibus -Dbindigns=cxx,mono -Ddotnet=true --prefix=$PWD/prefix build ``` - Build normally - Test `efl-mono-suite` Reviewers: felipealmeida Subscribers: cedric, #reviewers, #committers, woohyun Tags: #efl, #expertise_solutions Differential Revision: https://phab.enlightenment.org/D12156
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
from
b431cdd to
c7f288d
Compare
[Test Only] Don't return zero if RPC_E_CHANGED_MODE
RPC_E_CHANGED_MODE is indicating that COM was initialized in
multi-thread mode, to change this behavior we should use the
STAThreadAttribute attribute ('[STAThread]') on the Main().
ref: https://lauro.wordpress.com/2017/11/21/c-com-ole-e-threads/
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
from
99f4740 to
b31b00c
Compare
ERR:elementary ../src/lib/elementary/elm_module.c:114 _elm_module_find_as() Failed to load elementary module: 'prefs_iface': m
joaoantoniocardoso
force-pushed
the
devs/joaoantoniocardoso/dotnet
branch
from
b31b00c to
ea760d7
Compare
Coquinho
reviewed
Nov 13, 2020
Comment on lines
+128
to
+132
| #ifdef _MSC_VER | ||
| //, {"long", nullptr, [&] { return replace_base_type(regular, "long?"); }} | ||
| #else | ||
| , {"long", nullptr, [&] { return replace_base_opt_integer<long>(regular); }} | ||
| #endif |
Coquinho
reviewed
Nov 13, 2020
| { | ||
| public static void TestAdd() | ||
| { | ||
| /* |
Contributor
There was a problem hiding this comment.
Maybe #ifnot sys_windows to disable them only when building for windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.