Skip to content

Conversation

@byronkarlen
Copy link

@byronkarlen byronkarlen commented Jan 13, 2026

Why

Support for third-party sign in (Apple/Google/GitHub). eas login should eventually default to this but it would be a breaking change.

How

Test Plan

@byronkarlen byronkarlen marked this pull request as draft January 13, 2026 22:57
@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

Size Change: -815 B (0%)

Total Size: 53.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.3 MB -815 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.59%. Comparing base (e51fe11) to head (f7e613d).

Files with missing lines Patch % Lines
...es/eas-cli/src/user/expoBrowserAuthFlowLauncher.ts 28.58% 5 Missing ⚠️
packages/eas-cli/src/commands/account/login.ts 0.00% 1 Missing ⚠️
...er/fetchSessionSecretAndUserFromBrowserAuthFlow.ts 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3312      +/-   ##
==========================================
+ Coverage   49.59%   49.59%   +0.01%     
==========================================
  Files         671      671              
  Lines       27991    27992       +1     
  Branches     5793     5798       +5     
==========================================
+ Hits        13879    13880       +1     
  Misses      12921    12921              
  Partials     1191     1191              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@byronkarlen
Copy link
Author

/changelog-entry new-feature Add --browser flag to login command for browser-based authentication

@byronkarlen byronkarlen force-pushed the byron/browser-auth-flow branch from 7f75b00 to f7e613d Compare January 13, 2026 23:29
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants