Fix example/with-camera: Camera re-initialization and Layout fix#590
Open
mirsahib wants to merge 1 commit intoexpo:masterfrom
Open
Fix example/with-camera: Camera re-initialization and Layout fix#590mirsahib wants to merge 1 commit intoexpo:masterfrom
mirsahib wants to merge 1 commit intoexpo:masterfrom
Conversation
Re-initializes CameraView on screen focus using useFocusEffect and wraps CameraView with controls in a fragment to address children limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two key improvements to the camera functionality in
with-camera/App.tsx:Camera Re-initialization on Focus:
useFocusEffectfromexpo-routerto increment acameraKeystate variable whenever thescreen gains focus. The
CameraViewcomponent now uses thiscameraKeyas its key prop.CameraViewcomponent is re-mounted andre-initialized when the user navigates back to this screen. This addresses potential issues where the
camera might not function correctly after being unfocused or backgrounded, providing a more robust user
experience. The use of useCallback with useFocusEffect is also good practice for performance.
CameraViewChildren Limitation Fix:CameraViewcomponent and its associated shutter controls (View component) are now wrappedwithin a React Fragment (<></>).
CameraViewdoes not support children. By makingthe
CameraViewand the controls siblings within a fragment, you can then use absolute positioning forthe controls, ensuring they render correctly on top of the camera feed without causing inconsistent
behavior or crashes.