This repository was archived by the owner on Jun 7, 2019. It is now read-only.
updates example application packages to latest, updated react-naviga…#41
Open
ameljohny wants to merge 2 commits intoexpo:masterfrom
Open
updates example application packages to latest, updated react-naviga…#41ameljohny wants to merge 2 commits intoexpo:masterfrom
ameljohny wants to merge 2 commits intoexpo:masterfrom
Conversation
Author
|
Removing Header |
frusdelion
added a commit
to harborfront/videoplayer
that referenced
this pull request
Dec 31, 2018
Contributor
|
Hi @ameljohny- really appreciate the PR, but unfortunately this repo isn't maintained anymore, so we suggest using https://github.com/ihmpavel/expo-video-player instead (we actually point to this repo anyways in the Expo Video docs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates package.json.
Updates react-navigation api
Updates icons
note: adding "playThroughEarpieceAndroid": True | False { "@expo/videoplayer": "0.4.0", },to remove the warning [Unhandled promise rejection: Error: Audio mode attempted to be set without the required keys: ["playThroughEarpieceAndroid"]]