This repository was archived by the owner on Jun 7, 2019. It is now read-only.
Allow hide fullscreen button in video control#7
Open
nattatorn-dev wants to merge 2 commits intoexpo:masterfrom
Open
Allow hide fullscreen button in video control#7nattatorn-dev wants to merge 2 commits intoexpo:masterfrom
nattatorn-dev wants to merge 2 commits intoexpo:masterfrom
Conversation
Author
|
My application work in portrait mode only and I don't need to show full screen button |
suhshinhwang
reviewed
Jan 3, 2018
| /** | ||
| * Allow fullscreen button | ||
| */ | ||
| fs: PropTypes.bool, |
There was a problem hiding this comment.
Change this name to showFullscreenButton? Makes the code self-explanatory
Contributor
|
Fixed in |
So this should work already @abi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it possible to hide full screen button?