Skip to content

Comments

Patch/update ts types and sass#488

Merged
mrbinky3000 merged 5 commits intomasterfrom
patch/update-ts-types-and-sass
Dec 23, 2025
Merged

Patch/update ts types and sass#488
mrbinky3000 merged 5 commits intomasterfrom
patch/update-ts-types-and-sass

Conversation

@mrbinky3000
Copy link
Collaborator

@mrbinky3000 mrbinky3000 commented Dec 23, 2025

What:

  • Migrating away from node-sass to sass to avoid install issue where users need python to build node-sass
  • Updated types for Image component and other polymorphic components that can change their HTML tag. Image, for instance, can be an "img" tag or a "div" tag, or any valid HTML tag at all.
  • updating to newer node version in .nvmrc file
  • updating all github actions to use newer node

Why:

  • node-sass to sass needed to avoid python dependency
  • updating types because I need to pass width and height attributes to the Image component but the Image component was listed as extending only the "div" HTML attributes. Image is polymorphic and can be any valid HTML tag.
  • updating node version is for security reasons

How:

  • Cautiously. A lot of people use this.

Checklist:

  • Documentation added/updated
  • Typescript definitions updated
  • Tests added and passing
  • Ready to be merged

@mrbinky3000 mrbinky3000 merged commit bf305fd into master Dec 23, 2025
2 checks passed
@mrbinky3000 mrbinky3000 deleted the patch/update-ts-types-and-sass branch December 23, 2025 23:39
mrbinky3000 added a commit that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant