Skip to content

[BUGFIX] Assign class property before initialization #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-g-codappix merged 1 commit into from
Sep 12, 2025
Merged

[BUGFIX] Assign class property before initialization #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Classes/Domain/Finisher/Form/AddToCartFinisher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

class AddToCartFinisher extends AbstractFinisher
{
protected Cart $cart;
protected ?Cart $cart = null;

protected array $configurations;

Expand All @@ -47,9 +47,9 @@ public function __construct(

protected function executeInternal(): ?string
{
$cart = $this->sessionHandler->restoreCart($this->configurations['settings']['cart']['pid']);
$this->cart = $this->sessionHandler->restoreCart($this->configurations['settings']['cart']['pid']);

if (!$cart instanceof Cart) {
if (!$this->cart instanceof Cart) {
$cart = $this->cartUtility->getNewCart($this->configurations);
$this->sessionHandler->writeCart($this->configurations['settings']['cart']['pid'], $cart);
}
Expand Down
2 changes: 1 addition & 1 deletion Documentation/guides.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
interlink-shortcode="extcode/cart"
/>
<project title="Cart"
release="11.4.12"
release="11.4.13"
version="11.4"
copyright="2018 - 2025"
/>
Expand Down
2 changes: 1 addition & 1 deletion ext_emconf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
'title' => 'Cart',
'description' => 'Shopping Cart(s) for TYPO3',
'category' => 'plugin',
'version' => '11.4.12',
'version' => '11.4.13',
'state' => 'stable',
'author' => 'Daniel Gohlke',
'author_email' => 'ext@extco.de',
Expand Down