confirm prompt should not have a continue options#65
Open
trbKnl wants to merge 1 commit intoeyra:masterfrom
Open
confirm prompt should not have a continue options#65trbKnl wants to merge 1 commit intoeyra:masterfrom
trbKnl wants to merge 1 commit intoeyra:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
If input validation fails the confirm prompt is triggered (see also script.py). Participant should not be allowed to continue.
Participants can now click continue, and will register as completed, as they have completed the data share task. They will receive an incentive, although they were not able to provide a valid ddp.
The continue was only there, to prevent participant from getting stuck, because Next did not implement a "back or close" button. Next back then did not keep track of completion status
Solution
remove the continue option from the confirm prompt