Skip to content

Comments

feat(api): rename /config to /setup#70

Merged
ssilvius merged 2 commits intomainfrom
feat/setup-endpoint
Jan 24, 2026
Merged

feat(api): rename /config to /setup#70
ssilvius merged 2 commits intomainfrom
feat/setup-endpoint

Conversation

@ssilvius
Copy link
Contributor

Summary

  • Renames the /config endpoint to /setup for config file download

Closes #47

Test plan

  • GET /setup?key=<api_key> returns ctd.toml
  • GET /setup?key=<api_key>&format=json returns JSON config

🤖 Generated with Claude Code

Closes #47

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings January 24, 2026 08:09
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the config download API endpoint from /config to /setup to align the public route with “setup” terminology.

Changes:

  • Remounts the existing config download router under /setup instead of /config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

app.route('/api-keys', apiKeysApp);
app.route('/calibration', calibrationApp);
app.route('/config', configApp);
app.route('/setup', configApp);
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are app-level Vitest smoke tests (e.g., /health, 404), but nothing asserting that the config download route is mounted at the new /setup path. Adding a simple test that /setup responds (e.g., 401 for missing/invalid key) would prevent regressions on future route refactors.

Copilot uses AI. Check for mistakes.
app.route('/api-keys', apiKeysApp);
app.route('/calibration', calibrationApp);
app.route('/config', configApp);
app.route('/setup', configApp);
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the mount from /config to /setup is a breaking API change: any existing clients calling /config will now get a 404. If backward compatibility is desired, consider temporarily mounting the same router on both paths (or adding a redirect/deprecation response on /config) and documenting a removal timeline.

Suggested change
app.route('/setup', configApp);
app.route('/setup', configApp);
app.route('/config', configApp);

Copilot uses AI. Check for mistakes.
@ssilvius ssilvius merged commit 0e4766f into main Jan 24, 2026
7 checks passed
@ssilvius ssilvius deleted the feat/setup-endpoint branch January 24, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Setup Page UI (SaaS) - User config download interface

1 participant