Conversation
Closes #47 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Renames the config download API endpoint from /config to /setup to align the public route with “setup” terminology.
Changes:
- Remounts the existing config download router under
/setupinstead of/config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| app.route('/api-keys', apiKeysApp); | ||
| app.route('/calibration', calibrationApp); | ||
| app.route('/config', configApp); | ||
| app.route('/setup', configApp); |
There was a problem hiding this comment.
There are app-level Vitest smoke tests (e.g., /health, 404), but nothing asserting that the config download route is mounted at the new /setup path. Adding a simple test that /setup responds (e.g., 401 for missing/invalid key) would prevent regressions on future route refactors.
| app.route('/api-keys', apiKeysApp); | ||
| app.route('/calibration', calibrationApp); | ||
| app.route('/config', configApp); | ||
| app.route('/setup', configApp); |
There was a problem hiding this comment.
Changing the mount from /config to /setup is a breaking API change: any existing clients calling /config will now get a 404. If backward compatibility is desired, consider temporarily mounting the same router on both paths (or adding a redirect/deprecation response on /config) and documenting a removal timeline.
| app.route('/setup', configApp); | |
| app.route('/setup', configApp); | |
| app.route('/config', configApp); |
Summary
/configendpoint to/setupfor config file downloadCloses #47
Test plan
GET /setup?key=<api_key>returns ctd.tomlGET /setup?key=<api_key>&format=jsonreturns JSON config🤖 Generated with Claude Code