Open
Conversation
…ncy spectrum with negligible additional computation.
…transform is now applied after (before) the first transform is completed. This reduces the size of the problem, so the computation is less expensive.
…transform is now applied after (before) the first transform is completed. This reduces the size of the problem, so the computation is less expensive.
unalmis
added a commit
to PlasmaControl/DESC
that referenced
this pull request
Aug 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second of two pull requests to improve the FFT interpolation.
The algorithm implemented in #116 (which improves on the implementation in the
mainbranch without any drawbacks), is ideal for interpolation from spectral to real space. For example, given the coefficients of a 2D Fourier series, the optimal way to evaluate that series at uniform points is to compute two sets of 1-dimensional FFTs as done in #116.When interpolating from real space to real space in 2D, there are four sets of 1-dimensional FFTs to be computed. In some applications, it is of interest to interpolate to a rotated grid which has less density than the original aligned grid. When interpolating to such a grid with less density, it is always better to perform the FFTs such that each dimension is interpolated from real space to real space iteratively.