Cpe chrome fixes #258
Open
Cpe chrome fixes #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Bug: presently a chrome extension profile with
nilvalues is passed to profile cookbook unaltered. Fixed by properly compacting nested chrome extension profiles.Bug: Better check for if Chrome is installed on Windows - checks vanilla
Program Filesand respectsvalidate_installed.Style: Replaces
Hash.reject { |_k, v| v.nil? }withHash.compact.Bug: presently if both master prefs and profile prefs are not defined, an old master prefs file might still be left on disk. Additionally, if master prefs are defined but profile prefs are not, a entirely empty profile may still be sent to profiles cookbook. Resolved by always executing master prefs management - it should never no-op - before no-oping on an empty profile prefs definition.
Special notes for your reviewer:
Tested within our macOS/Windows fleet.
Does this PR introduce a user-facing change?:
It might fix a broken chrome extensions profile!