Add comprehensive tests for library code #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add test coverage for Bookworm library modules. Creates a new spec/lib/ directory with tests for: - parsers/rubocop.rb - AST parsing and EMPTY_RUBOCOP_AST handling - parsers/json.rb - JSON parsing - parser_base.rb - Abstract base class error behavior - exceptions.rb - ClassLoadError exception - keys.rb - BOOKWORM_KEYS structure and defaults - infer_base_classes.rb - InferRule class and load_rule_class methods - infer_engine.rb - Rule processing against KnowledgeBase - report_builder.rb - BaseReport class and load_report_class methods - crawler.rb - File discovery and parsing (mocked filesystem) - configuration.rb - Configuration loading (mocked filesystem) Also expands knowledge_base_spec.rb with tests for resources, providers, recipejson, metadatajson, accessors, and edge cases. Total: 95 tests, all passing. Differential Revision: D90409494
|
@dafyddcrosby has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90409494. |
|
This pull request has been merged in 73d8542. |
meta-codesync bot
pushed a commit
to facebook/chef-cookbooks
that referenced
this pull request
Jan 12, 2026
Summary: X-link: facebook/bookworm#11 Add test coverage for Bookworm library modules. Creates a new spec/lib/ directory with tests for: - parsers/rubocop.rb - AST parsing and EMPTY_RUBOCOP_AST handling - parsers/json.rb - JSON parsing - parser_base.rb - Abstract base class error behavior - exceptions.rb - ClassLoadError exception - keys.rb - BOOKWORM_KEYS structure and defaults - infer_base_classes.rb - InferRule class and load_rule_class methods - infer_engine.rb - Rule processing against KnowledgeBase - report_builder.rb - BaseReport class and load_report_class methods - crawler.rb - File discovery and parsing (mocked filesystem) - configuration.rb - Configuration loading (mocked filesystem) Also expands knowledge_base_spec.rb with tests for resources, providers, recipejson, metadatajson, accessors, and edge cases. Total: 95 tests, all passing. Reviewed By: skywalk7 Differential Revision: D90409494 fbshipit-source-id: a1aafee51fc6c42aa93d1e1c2a14b2b040248d10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add test coverage for Bookworm library modules. Creates a new spec/lib/
directory with tests for:
Also expands knowledge_base_spec.rb with tests for resources, providers,
recipejson, metadatajson, accessors, and edge cases.
Total: 95 tests, all passing.
Differential Revision: D90409494