buck2: don't add tls_config when URI does not call for it#174
Closed
krallin wants to merge 1 commit intofacebook:mainfrom
Closed
buck2: don't add tls_config when URI does not call for it#174krallin wants to merge 1 commit intofacebook:mainfrom
krallin wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Like it says in the title. Right now Tonic will try to connect using TLS if you pass `tls_config` even if the URI clearly does not call for it. See: facebook#156 Test Plan: We have tests internally for the HTTPS case. The non-HTTPS scenario is unfortunately one for which we lack test coverage right now, but let's at least unbreak this to start. I did test that this works locally with non-TLS Build Barn.
facebook-github-bot
added
the
CLA Signed
krallin
changed the title
Contributor
|
@krallin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Thank you :) I was waiting for this to push my example of a BuildBarn configuration. With notes about how to use the bb-deployments repository. And some caveats about the not-yet plumbed instance name prefix. I'll rebase onto your example and submit a diff, with mostly documentation, for you to review. |
Contributor
Author
|
Ah, i actually submitted a separate diff for a build barn example already
(since I was testing with it), but please feel free to suggest improvements
to it, that’d be welcome!
…On Tue, 18 Apr 2023 at 13:37, Nils Wireklint ***@***.***> wrote:
Thank you :) I was waiting for this to push my example of a BuildBarn
configuration. With notes about how to use the bb-deployments repository.
And some caveats about the not-yet plumbed instance name prefix. I'll
rebase onto your example and submit a diff, with mostly documentation.
—
Reply to this email directly, view it on GitHub
<#174 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANIHVTGBXVLUCSTERSRRXDXBZ4IHANCNFSM6AAAAAAXBOZWVY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
Yeah I saw that :) it's great to have an Buildbarn example: here is the documentation PR: #179 |
benbrittain
pushed a commit
to benbrittain/buck2
that referenced
this pull request
Apr 23, 2023
Summary: Like it says in the title. Right now Tonic will try to connect using TLS if you pass `tls_config` even if the URI clearly does not call for it. None of this is actually consistent with the GPRC naming spec, so let's just ban URIs that look like HTTP / HTTPS URIs, and then use a dedicated field for TLS / no TLS. See: facebook#156 Pull Request resolved: facebook#174 Test Plan: We have tests internally for the HTTPS case. The non-HTTPS scenario is unfortunately one for which we lack test coverage right now, but let's at least unbreak this to start. I did test that this works locally with non-TLS Build Barn. Reviewed By: ndmitchell, themarwhal Differential Revision: D45054439 Pulled By: krallin fbshipit-source-id: fe0c1e1d287c462e568527590ffa812e7fb281c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Like it says in the title. Right now Tonic will try to connect using TLS if you pass
tls_configeven if the URI clearly does not call for it.See: #156
Test Plan:
We have tests internally for the HTTPS case. The non-HTTPS scenario is unfortunately one for which we lack test coverage right now, but let's at least unbreak this to start.
I did test that this works locally with non-TLS Build Barn.