feat(publish): Use trusted publishing (OIDC) for canary releases#11712
Merged
feat(publish): Use trusted publishing (OIDC) for canary releases#11712
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: -559 B (0%) Total Size: 11.8 MB
ℹ️ View Unchanged
|
|
Size Change: -975 B (-0.01%) Total Size: 12.3 MB
ℹ️ View Unchanged
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm supply chain security model is changing:
Our canary workflow broke in December due to tightened security rules.
Let's adopt the new security model and fix the canary publish workflow.
I'm considering this a feature because it improves security for our users.
This PR should fix the canary publish after having configured
publish.ymlas the repo's trusted publishing workflow on npm for all packages of this repo. Unfortunately, this process is manual, and we will have to configure any new package we create on npm.Note: I have configured
publish.ymlbecause later we'll likely set up trusted publishing for actual releases, and not limit ourselves to canary releases. We can only set a single workflow file as the trusted one on npm, so both canary/release publishes would have to happen in the same file.Note: to support OIDC, we need to upgrade to Lerna 9. Since it's not compatible with Node 20.0, I only install it locally during the workflow run, and keep node retrocompatibility for our whole monorepo. We'll be able to cleanup that soon.
Test Plan
It should publish