-
Notifications
You must be signed in to change notification settings - Fork 372
[Nexthop][fboss2-dev] Add a "fboss2 config rollback" command. #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
benoit-nexthop
wants to merge
1
commit into
facebook:main
from
nexthop-ai:fboss2-cli-prototype_part06
Closed
[Nexthop][fboss2-dev] Add a "fboss2 config rollback" command. #758
benoit-nexthop
wants to merge
1
commit into
facebook:main
from
nexthop-ai:fboss2-cli-prototype_part06
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41072eb to
3d5d58a
Compare
This was referenced Dec 23, 2025
0215db8 to
8691fd6
Compare
0323730 to
2a99c5f
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 10, 2026
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` This adds just the command `fboss2-dev config session diff`. Note: this change is part of a series, the previous one is #756, the next one is #758. Pull Request resolved: #757 Test Plan: Unit tests. ## Sample usage ``` [admin@fboss101 benoit]$ ./fboss2-dev show interface | head +-----------+--------+-------+------+------+------------------------------+----------------------------+ | Interface | Status | Speed | VLAN | MTU | Addresses | Description | -------------------------------------------------------------------------------------------------------- | eth1/1/1 | down | 800G | 2001 | 1500 | 10.0.0.0/24 | Test port for diff command | | | | | | | 2400::/64 | | | | | | | | fe80::b4db:91ff:fe95:ff07/64 | | +-----------+--------+-------+------+------+------------------------------+----------------------------+ | eth1/2/1 | down | 200G | 2003 | 9216 | 11.0.0.0/24 | Another test description | | | | | | | 2401::/64 | | | | | | | | fe80::b4db:91ff:fe95:ff07/64 | | [admin@fboss101 benoit]$ ./fboss2-dev config interface eth1/1/1 mtu 9000 Successfully set MTU for interface(s) eth1/1/1 to 9000 [admin@fboss101 benoit]$ ./fboss2-dev config interface eth1/2/1 description 'This is a test.' Successfully set description for interface(s) eth1/2/1 [admin@fboss101 benoit]$ ./fboss2-dev config session diff --- /etc/coop/agent.conf 2025-11-05 12:49:14.497415902 -0800 +++ /home/admin/.fboss2/agent.conf 2025-11-05 12:57:27.123758309 -0800 @@ -369,7 +369,7 @@ ], "isStateSyncDisabled": true, "isVirtual": false, - "mtu": 1500, + "mtu": 9000, "routerID": 0, "scope": 0, "type": 1, @@ -2230,7 +2230,7 @@ }, { "conditionalEntropyRehash": false, - "description": "Another test description", + "description": "This is a test.", "drainState": 0, "expectedLLDPValues": { "2": "eth1/6/1" ``` ``` [admin@fboss101 benoit]$ ./fboss2-dev config history Revision Owner Commit Time ------------------------------------------ r1 root 2025-11-05 13:26:58 r2 root 2025-11-05 13:27:35 r3 root 2025-11-05 13:28:13 r4 admin 2025-11-05 14:37:51 r5 admin 2025-11-05 14:38:31 ``` You can also do `fboss2-dev config diff r2 r4` or `fboss2-dev config diff r1 current` to compare committed revisions. Reviewed By: shiva-menta Differential Revision: D90277033 Pulled By: joseph5wu fbshipit-source-id: 5fcdac6c2e01c55169d68a8f5d227da241d8b65e
059f6c0 to
442a227
Compare
442a227 to
5d3de93
Compare
|
@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D90739629. |
|
@joseph5wu merged this pull request in 3e1bd59. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` This adds just the command `fboss2 config history`. Note: this change is part of a series, the previous one is #758, the next one is #760. Pull Request resolved: #759 Test Plan: Unit tests. ## Sample usage ``` [admin@fboss101 benoit]$ ./fboss2-dev config history Revision Owner Commit Time ------------------------------------------ r1 root 2025-11-05 13:26:58 r2 root 2025-11-05 13:27:35 r3 root 2025-11-05 13:28:13 r4 admin 2025-11-05 14:37:51 r5 admin 2025-11-05 14:38:31 ``` Differential Revision: D90801711 Pulled By: joseph5wu fbshipit-source-id: b404a043258c4bb74cbbf658ee0055c6d8e7d84f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This adds just the command
fboss2-dev config rollback.Note: this change is part of a series, the previous one is #757, the next one is #759.
Test Plan
Unit tests.
Sample usage
In this state:
One can do
fboss2 config rollback r3or justfboss2 config rollbackto just go back to whatever was the last revision. Doing so creates a new revision (r6in this example) that is identical to the one we rolled back to.