Skip to content

Conversation

@benoit-nexthop
Copy link
Contributor

@benoit-nexthop benoit-nexthop commented Dec 18, 2025

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Add some helper code to process interface-list arguments.

Note: this change is part of a series, the previous one is #759, the next one is #761.

Test Plan

Unit tests. New end to end tests for this command are in #783.

Sample usage

[admin@fboss101 benoit]$ ./fboss2-dev show interface | head
+-----------+--------+-------+------+------+------------------------------+----------------------------+
| Interface | Status | Speed | VLAN | MTU  | Addresses                    | Description                |
--------------------------------------------------------------------------------------------------------
| eth1/1/1  | down   | 800G  | 2001 | 1500 | 10.0.0.0/24                  | Test port for diff command |
|           |        |       |      |      | 2400::/64                    |                            |
|           |        |       |      |      | fe80::b4db:91ff:fe95:ff07/64 |                            |
+-----------+--------+-------+------+------+------------------------------+----------------------------+
| eth1/2/1  | down   | 200G  | 2003 | 9216 | 11.0.0.0/24                  | Another test description   |
|           |        |       |      |      | 2401::/64                    |                            |
|           |        |       |      |      | fe80::b4db:91ff:fe95:ff07/64 |                            |
[admin@fboss101 benoit]$ ./fboss2-dev config interface eth1/2/1 description 'This is a test.'
Successfully set description for interface(s) eth1/2/1
[admin@fboss101 benoit]$ ./fboss2-dev config session diff
--- /etc/coop/agent.conf	2025-11-05 12:49:14.497415902 -0800
+++ /home/admin/.fboss2/agent.conf	2025-11-05 12:57:27.123758309 -0800
@@ -2230,7 +2230,7 @@
       },
       {
         "conditionalEntropyRehash": false,
-        "description": "Another test description",
+        "description": "This is a test.",
         "drainState": 0,
         "expectedLLDPValues": {
           "2": "eth1/6/1"
[admin@fboss101 benoit]$ ./fboss2-dev config session commit
Config session committed successfully and config reloaded.
[admin@fboss101 benoit]$ ./fboss2-dev show interface | head
+-----------+--------+-------+------+------+------------------------------+----------------------------+
| Interface | Status | Speed | VLAN | MTU  | Addresses                    | Description                |
--------------------------------------------------------------------------------------------------------
| eth1/1/1  | down   | 800G  | 2001 | 1500 | 10.0.0.0/24                  | Test port for diff command |
|           |        |       |      |      | 2400::/64                    |                            |
|           |        |       |      |      | fe80::b4db:91ff:fe95:ff07/64 |                            |
+-----------+--------+-------+------+------+------------------------------+----------------------------+
| eth1/2/1  | down   | 200G  | 2003 | 9216 | 11.0.0.0/24                  | This is a test.            |
|           |        |       |      |      | 2401::/64                    |                            |
|           |        |       |      |      | fe80::b4db:91ff:fe95:ff07/64 |                            |

@meta-cla meta-cla bot added the CLA Signed label Dec 18, 2025
@benoit-nexthop benoit-nexthop marked this pull request as ready for review December 18, 2025 00:38
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part08 branch 2 times, most recently from 8759fa4 to b4b36a3 Compare December 23, 2025 21:39
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part08 branch 5 times, most recently from 321f876 to 95c2d20 Compare December 30, 2025 15:53
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part08 branch 3 times, most recently from cf2e397 to 5ee5d93 Compare January 7, 2026 06:29
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part08 branch 4 times, most recently from d875ba2 to 323ea6e Compare January 14, 2026 21:12
@benoit-nexthop benoit-nexthop force-pushed the fboss2-cli-prototype_part08 branch from 323ea6e to 0724b1a Compare January 15, 2026 21:36
meta-codesync bot pushed a commit that referenced this pull request Jan 16, 2026
Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

This adds just the command `fboss2 config history`.

Note: this change is part of a series, the previous one is #758, the next one is #760.

Pull Request resolved: #759

Test Plan:
Unit tests.

## Sample usage

```
[admin@fboss101 benoit]$ ./fboss2-dev config history
 Revision  Owner  Commit Time
------------------------------------------
 r1        root   2025-11-05 13:26:58
 r2        root   2025-11-05 13:27:35
 r3        root   2025-11-05 13:28:13
 r4        admin  2025-11-05 14:37:51
 r5        admin  2025-11-05 14:38:31
```

Differential Revision: D90801711

Pulled By: joseph5wu

fbshipit-source-id: b404a043258c4bb74cbbf658ee0055c6d8e7d84f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants