[Accton][MP3N] Remove hard-coded Preemphasis to fix create_port_serdes failure #807
Conversation
…s failure
Description:
Currently, the FBOSS Preemphasis value is hard-coded to -15.
cpp
std::optional<uint32_t> ChenabAsic::getPortSerdesPreemphasis() const {
return -15; // must be same as pre1
}
When a different SI configuration is required, the Preemphasis value differs from TxFirPre1, which
causes the call to the SAI API api_->create_port_serdes() to fail and return an error.
The current workaround is to not specify a default Preemphasis value and instead return nullopt.
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Description:
Issue Summary: The current ASIC implementation contains a hard-coded Preemphasis value of -15, which causescreate_port_serdes()API failures when Signal Integrity (SI) configurations require different Preemphasis values than the default TxFirPre1 setting.
Root Cause:
Solution: