[Accton][MP3N] Support SAI version 1.17.1 #810
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: We tried to build FBOSS using NVIDIA SDK v4.8.3054 together with SAIBuild2511.34.1.52, where the SAI API version is 1.17.1. However, a compilation error occurred: Error message: build-helper.py: error: argument sai_version: invalid choice: '1.17.1' (choose from '1.13.2', '1.14.0', '1.15.0', '1.15.3', '1.16.0', '1.16.1', '1.16.3') To resolve this, version 1.17.1 was added to the list of supported SAI versions in build-helper.py.
Contributor
|
@vincent9926-Accton : Can you move the Description in this PR to the "Summary" session. And please also include any Test plan for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Description:
We tried to build FBOSS using NVIDIA SDK v4.8.3054 together with SAIBuild2511.34.1.52, where the SAI API version is 1.17.1. However, a compilation error occurred:
Error message:
build-helper.py: error: argument sai_version: invalid choice: '1.17.1' (choose from '1.13.2', '1.14.0', '1.15.0', '1.15.3', '1.16.0', '1.16.1', '1.16.3')
To resolve this, version 1.17.1 was added to the list of supported SAI versions in build-helper.py.
Test Plan
The Ensemble Link Test results are as follows.
Running all tests took 1:34:16.377938 between 2026-01-14 03:31:52.378063 and 2026-01-14 05:06:08.756001
[ OK ] warm_boot.AgentEnsembleOpticsTest.verifyTxRxLatches (311935 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.ecmpShrink (124139 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.asicLinkFlap (248892 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.getTransceivers (103877 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.trafficRxTx (91876 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.opticsTxDisableRandomPorts (173995 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.opticsTxDisableEnable (143883 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.qsfpColdbootAfterAgentUp (223943 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.iPhyInfoTest (128802 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.verifyIphyFecBerCounters (158935 ms)
[ OK ] warm_boot.AgentEnsembleLinkTest.clearIphyInterfaceCounters (116839 ms)
[ OK ] warm_boot.AgentEnsembleEmptyLinkTest.CheckInit (106813 ms)
[ FAILED ] cold_boot.AgentEnsembleLinkSanityTestDataPlaneFlood.warmbootIsHitLess (0 ms)
[ OK ] warm_boot.AgentEnsembleLinkSanityTestDataPlaneFlood.warmbootIsHitLess (98915 ms)
[ FAILED ] cold_boot.AgentEnsembleLinkSanityTestDataPlaneFlood.qsfpWarmbootIsHitLess (0 ms)
[ OK ] warm_boot.AgentEnsembleLinkSanityTestDataPlaneFlood.qsfpWarmbootIsHitLess (111892 ms)
Summary:
OK : 14
FAILED : 2
SKIPPED : 0
TIMEOUT : 0
There is the log file
fboss_bins_nv_20260106_17_02_55_e9bb856e91_Switch_SDK_v4_8_3054_Release_SAIBuild2511_34_1_52_tar.tar.zst.zip