Skip to content

Conversation

@zhongedward
Copy link
Contributor

@zhongedward zhongedward commented Jan 15, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

This PR is for the Icecube sensor_service.json and platform_manager.json.The changes are divided into two main parts.
1.Based on the current factory production information, a new SMB combination v 2 3 10 was added for DVT.Therefore, we are adding this configuration to sensor_service.json.
image

In this PR, the following 4 sensors are placed in the SMB versionedSensors v 2 3 10 field.
SMB_XP0R72V_PB_TRVDD_0_VOUT
SMB_XP0R72V_PB_TRVDD_1_VOUT
SMB_XP0R72V_PB_TRVDD_2_VOUT
SMB_XP0R72V_PB_TRVDD_3_VOUT

2.The fboss_iob_i2c driver is added to requiredKmodsToLoad in platform_manager.json to preload the driver, which helps avoid timing issues. Please refer to this PR for more context: PR#491
More details: Post:Delay in creating iob_i2c_master bus

Test Plan

1.Verified the format using the JSONLint website.
2.Used the jq command to pretty-print the format.
3.Compilation and config validation have passed.
4.Run platform_manager,sensor_service,sensor_service_hw_test on device with SMB v 2 3 10 successfully.

SMB v 2 3 10
image

icecube_pm_test_log_2026_1_14.txt
icecube_sensor_test_log_2026_1_14.txt

@meta-cla meta-cla bot added the CLA Signed label Jan 15, 2026
@zhongedward zhongedward marked this pull request as ready for review January 15, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant