[Nexthop] Upgrade FBOSS Distro to support systemd services #813
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice for FBOSS platform_manager
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please provide enough information so
that others can review your pull request. -->
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the
files I modified in this PR. You can install the linters by running `pip
install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`
Upgraded FBOSS Distro to support systemd services and add `systemd`
service integration for `platform_manager` to enable automatic startup
on boot.
<!-- Explain the motivation for making this change and any other context
that you think would help reviewers of your code. What existing problem
does the pull request solve? -->
- Add `services/platform_manager.service` systemd unit file
- Update `build_image_in_container.sh` to copy service files from
`services/` directory to the root overlay
- Update `config.sh` to enable `platform_manager.service` during image
build
<!-- Demonstrate the code is solid. Example: The exact commands you ran
and their output, screenshots / videos if the pull request changes the
user interface. How exactly did you verify that your PR solves the issue
you wanted to solve? -->
- Built PXE and ONIE images successfully
- Verified service installs and enables correctly
- Confirmed journald logging works
<!-- If a relevant Github issue exists for this PR, please make sure you
link that issue to this PR -->
```
[root@gold222 ~]# systemctl status platform_manager.service
platform_manager.service - FBOSS Platform Manager
Loaded: loaded (/usr/lib/systemd/system/platform_manager.service; enabled; preset: disabled)
```
```
[root@gold222 fboss]# journalctl -u platform_manager
...
Jan 09 07:53:25 gold222 systemd[1]: platform_manager.service: Scheduled restart job, restart counter is at 5.
Jan 09 07:53:25 gold222 systemd[1]: Stopped FBOSS Platform Manager.
Jan 09 07:53:25 gold222 systemd[1]: Started FBOSS Platform Manager.
Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.284380 1112 PlatformNameLib.cpp:56] Getting platform na
me from bios using dmidecode ...
Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.286804 1112 PlatformNameLib.cpp:65] Platform name infer
red from bios: NH-4010
Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.286823 1112 PlatformNameLib.cpp:67] Platform name mappe
d: NH-4010
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Upgraded FBOSS Distro to support systemd services and add
systemdservice integration forplatform_managerto enable automatic startup on boot.services/platform_manager.servicesystemd unit filebuild_image_in_container.shto copy service files fromservices/directory to the root overlayconfig.shto enableplatform_manager.serviceduring image buildTest Plan