fix: Fix iOS build CI (.xcframework missing)#1619
Open
mrousavy wants to merge 1 commit intofacebook:mainfrom
Open
fix: Fix iOS build CI (.xcframework missing)#1619mrousavy wants to merge 1 commit intofacebook:mainfrom
.xcframework missing)#1619mrousavy wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the build CI which previously failed silently.
See the last actions run, in the end of the logs it fails silently:
This is fixed by upgrading macOS 14 to macOS 15, or more precise; upgrading Xcode 15.4 to Xcode 16 (which is always installed on a macos-15 runner, hence the removal of that unneeded extra action)
This is inspired by mrousavy/hermes-release-build, which I just created for this. It works on my CI with macos-15 and Xcode 16 now.
Test Plan
Run the CI and check logs