Skip to content

fix: Fix iOS build CI (.xcframework missing)#1619

Open
mrousavy wants to merge 1 commit intofacebook:mainfrom
mrousavy:fix/ios-build
Open

fix: Fix iOS build CI (.xcframework missing)#1619
mrousavy wants to merge 1 commit intofacebook:mainfrom
mrousavy:fix/ios-build

Conversation

@mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Feb 15, 2025

Summary

Fixes the build CI which previously failed silently.

See the last actions run, in the end of the logs it fails silently:

-- Up-to-date: /Users/runner/work/hermes/hermes/build_appletvsimulator/../destroot/include/jsi/decorator.h
-- Up-to-date: /Users/runner/work/hermes/hermes/build_appletvsimulator/../destroot/include/jsi/threadsafe.h
-- Up-to-date: /Users/runner/work/hermes/hermes/build_appletvsimulator/../destroot/include/jsi/jsilib.h
Creating universal framework for platforms: iphoneos iphonesimulator catalyst xros xrsimulator appletvos appletvsimulator
error: the path does not point to a valid framework: /Users/runner/work/hermes/hermes/destroot/Library/Frameworks/iphoneos/hermes.framework
rm: iphoneos: No such file or directory
rm: appletvos: No such file or directory
/Users/runner/work/hermes/hermes

This is fixed by upgrading macOS 14 to macOS 15, or more precise; upgrading Xcode 15.4 to Xcode 16 (which is always installed on a macos-15 runner, hence the removal of that unneeded extra action)

This is inspired by mrousavy/hermes-release-build, which I just created for this. It works on my CI with macos-15 and Xcode 16 now.

Test Plan

Run the CI and check logs

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants