Open
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
cortinico
approved these changes
Sep 18, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
force-pushed
the
export-D82313203-to-static_h
branch
from
d1458a5 to
3a9bde9
Compare
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 18, 2025
Summary:
This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is of type `<date>.0.0`.
Differential Revision: D82313203
Contributor
coado
force-pushed
the
export-D82313203-to-static_h
branch
from
3a9bde9 to
dbee74d
Compare
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 18, 2025
Summary:
This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is of type `<date>.0.0`.
Differential Revision: D82313203
Contributor
cortinico
requested changes
Sep 18, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 18, 2025
Summary:
This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is a version read from the `hermes-compiler/package.json`.
Differential Revision: D82313203
coado
force-pushed
the
export-D82313203-to-static_h
branch
from
dbee74d to
0b0be5d
Compare
Contributor
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 18, 2025
Summary:
This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is a version read from the `hermes-compiler/package.json`.
Differential Revision: D82313203
coado
force-pushed
the
export-D82313203-to-static_h
branch
from
0b0be5d to
5a1a508
Compare
Contributor
cortinico
approved these changes
Sep 19, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary:
This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is a version read from the `hermes-compiler/package.json`.
Reviewed By: cortinico
Differential Revision: D82313203
coado
force-pushed
the
export-D82313203-to-static_h
branch
from
5a1a508 to
e8670a2
Compare
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
Summary: Pull Request resolved: #1791 This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is a version read from the `hermes-compiler/package.json`. Reviewed By: cortinico Differential Revision: D82313203 fbshipit-source-id: 4c66368a077e19083d75bd3ae36380c2c5a1ded1
coado
added a commit
to coado/hermes
that referenced
this pull request
Sep 24, 2025
Summary: Pull Request resolved: facebook#1791 This diff sets version in `CMakeLists.txt` to `1.0.0` and configures build to pass `-DHERMES_RELEASE_VERSION=for RN ${hermesReleaseVersion}` where `hermesReleaseVersion` is a version read from the `hermes-compiler/package.json`. Reviewed By: cortinico Differential Revision: D82313203 fbshipit-source-id: 4c66368a077e19083d75bd3ae36380c2c5a1ded1
coado
added a commit
that referenced
this pull request
Sep 24, 2025
Set hermes release version in static_h (#1791)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This diff sets version in
CMakeLists.txtto1.0.0and configures build to pass-DHERMES_RELEASE_VERSION=${hermesReleaseVersion}wherehermesReleaseVersionis of type<date>.0.0.Differential Revision: D82313203