perf: optimize bigint compare() with static ints#1856
Draft
ChALkeR wants to merge 1 commit intofacebook:static_hfrom
Draft
perf: optimize bigint compare() with static ints#1856ChALkeR wants to merge 1 commit intofacebook:static_hfrom
ChALkeR wants to merge 1 commit intofacebook:static_hfrom
Conversation
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compare(_, 0),compare(_, 1),compare(_, -1)are used internallyNo need to convert rhs to bigint for those
Also used for 2 and -2 in exp path, but that's likely not significant there
Test Plan