Add isBinary parameter to ws$MessageListener type #55137
Closed
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90507002. |
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Jan 13, 2026
Summary: The `ws` library's `message` event passes `(data, isBinary)` to callbacks, but the flow-typed definition only included `data`. This caused Flow errors when correctly using `isBinary` to detect binary messages. This fix adds the missing `isBinary: boolean` parameter to `ws$MessageListener` in both flow-typed locations to keep them synchronized: - `xplat/js/tools/metro/flow-typed/npm/ws_v7.x.x.js` - `xplat/js/react-native-github/flow-typed/npm/ws_v7.x.x.js` This is backwards compatible - existing code that doesn't use `isBinary` will continue to work since for flow a function with fewer parameters is a subtype for callbacks. websocket was always sending both parameters and the javascript just ignored the second one. https://github.com/websockets/ws/blob/master/doc/ws.md#event-message Reviewed By: huntie Differential Revision: D90507002
emily8rown
force-pushed
the
export-D90507002
branch
from
f6c8832 to
f355d9d
Compare
Summary: Changelog: [Internal] - Add missing isBinary parameter to ws$MessageListener Flow type The `ws` library's `message` event passes `(data, isBinary)` to callbacks, but the flow-typed definition only included `data`. This caused Flow errors when correctly using `isBinary` to detect binary messages. This fix adds the missing `isBinary: boolean` parameter to `ws$MessageListener` in both flow-typed locations to keep them synchronized: - `xplat/js/tools/metro/flow-typed/npm/ws_v7.x.x.js` - `xplat/js/react-native-github/flow-typed/npm/ws_v7.x.x.js` This is backwards compatible - existing code that doesn't use `isBinary` will continue to work since for flow a function with fewer parameters is a subtype for callbacks. websocket was always sending both parameters and the javascript just ignored the second one. https://github.com/websockets/ws/blob/master/doc/ws.md#event-message Reviewed By: huntie Differential Revision: D90507002
emily8rown
force-pushed
the
export-D90507002
branch
from
f355d9d to
8c30f8d
Compare
meta-codesync bot
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 13, 2026
Summary: X-link: facebook/react-native#55137 Changelog: [Internal] - Add missing isBinary parameter to ws$MessageListener Flow type The `ws` library's `message` event passes `(data, isBinary)` to callbacks, but the flow-typed definition only included `data`. This caused Flow errors when correctly using `isBinary` to detect binary messages. This fix adds the missing `isBinary: boolean` parameter to `ws$MessageListener` in both flow-typed locations to keep them synchronized: - `xplat/js/tools/metro/flow-typed/npm/ws_v7.x.x.js` - `xplat/js/react-native-github/flow-typed/npm/ws_v7.x.x.js` This is backwards compatible - existing code that doesn't use `isBinary` will continue to work since for flow a function with fewer parameters is a subtype for callbacks. websocket was always sending both parameters and the javascript just ignored the second one. https://github.com/websockets/ws/blob/master/doc/ws.md#event-message Reviewed By: huntie Differential Revision: D90507002 fbshipit-source-id: 6ab78809213ec167416de35a12cd1fe5c328046f
Collaborator
|
This pull request was successfully merged by @emily8rown in a4bd79a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
wslibrary'smessageevent passes(data, isBinary)to callbacks, but the flow-typed definition only includeddata. This caused Flow errors when correctly usingisBinaryto detect binary messages.This fix adds the missing
isBinary: booleanparameter tows$MessageListenerin both flow-typed locations to keep them synchronized:xplat/js/tools/metro/flow-typed/npm/ws_v7.x.x.jsxplat/js/react-native-github/flow-typed/npm/ws_v7.x.x.jsThis is backwards compatible - existing code that doesn't use
isBinarywill continue to work since for flow a function with fewer parameters is a subtype for callbacks. websocket was always sending both parameters and the javascript just ignored the second one.https://github.com/websockets/ws/blob/master/doc/ws.md#event-message
Reviewed By: huntie
Differential Revision: D90507002