Skip to content

Fix Hermes opt mode for local mac runs #55138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
+7 −2
Closed

Fix Hermes opt mode for local mac runs #55138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions private/react-native-fantom/runner/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,12 @@ export function getHermesCompilerTarget(variant: HermesVariant): string {
export function getBuckModesForPlatform(
enableRelease: boolean = false,
): $ReadOnlyArray<string> {
let mode = enableRelease ? 'opt' : 'dev';
let modes = ['@//xplat/mode/react-native/granite'];
if (enableRelease) {
modes.push('@//xplat/mode/hermes/opt');
}

let mode = enableRelease ? 'opt' : 'dev';
if (enableRelease) {
if (EnvironmentOptions.enableASAN || EnvironmentOptions.enableTSAN) {
printConsoleLog({
Expand Down Expand Up @@ -101,7 +105,8 @@ export function getBuckModesForPlatform(
throw new Error(`Unsupported platform: ${os.platform()}`);
}

return ['@//xplat/mode/react-native/granite', osPlatform];
modes.push(osPlatform);
return modes;
}

// TODO: T240293839 Remove when we get rid of RN_USE_ANIMATION_BACKEND preprocessor flag
Expand Down
Loading