allow passing @stylexjs/babel-plugin aliases through react-strict-dom/babel-preset#294
Open
MoOx wants to merge 1 commit intofacebook:mainfrom
Open
allow passing @stylexjs/babel-plugin aliases through react-strict-dom/babel-preset#294MoOx wants to merge 1 commit intofacebook:mainfrom
MoOx wants to merge 1 commit intofacebook:mainfrom
Conversation
…/babel-preset Until facebook/stylex#856 is merged and released, this is kind of the only option to be able to write imports like defined in a tsconfig file.
Contributor
|
This just needs to be fixed in stylex |
Contributor
|
Remind me what aliases are needed for? Is it only for resolving the vars files? |
Contributor
Author
|
Basically writing absolute imports like |
Contributor
|
Yeah but what features require import resolution? Just the ones relying on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until facebook/stylex#856 is merged and released, this is kind of the only option to be able to write imports like defined in a tsconfig file.