Add native support for CSS variables with fixed names#328
Open
Add native support for CSS variables with fixed names#328
Conversation
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
necolas
force-pushed
the
native/passthrough-vars
branch
2 times, most recently
from
7efa95a to
ffcc380
Compare
StyleX on web has a feature that prevents auto-generation of scoped CSS var names created by `defineVars`. If the user-provided var key is a string that starts with `--`, the key is preserved as-is and its value can even be redefined in other `defineVars` calls. Adding support for this on native involves removing the legacy feature that converted kebab-case variable names to camelCase. Therefore, it's a breaking change that requires users to modify to the `customProperties` map (adding `--` prefix to all keys) passed to any use of the legacy `ThemeProvider` context. Close #73 Fix #50
necolas
force-pushed
the
native/passthrough-vars
branch
from
ffcc380 to
f5de618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StyleX on web has a feature that prevents auto-generation of scope CSS var names by
defineVars, if the user-provided var key is a string that starts with--.Adding support for this involves removing the legacy feature that converted kebab-case variable names to camelCase. Therefore, it's a breaking change that requires modification to the customProperties map passed to the legacy ThemeProvider context.
Close #73
Fix #50