Open
Conversation
Avoid setting styles if they are already the default for View. The cost of each style property in React Native is relatively high, so this micro optimization can still add up.
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
workflow: benchmarks/perf (native)Comparison of performance test results, measured in operations per second. Larger is better.
|
necolas
commented
Sep 16, 2025
| nativeProps.style.flexDirection = 'column'; | ||
| } | ||
| if (nativeProps.style.flexShrink != null) { | ||
| nativeProps.style.flexShrink = 0; |
Contributor
Author
There was a problem hiding this comment.
This might benefit from a little more logic, because I think flexShrink has an effect if the element is block but also a flex child
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid setting styles if they are already the default for View. The cost of each style property in React Native is relatively high, so this micro optimization can still add up.