Fallback to unstable_getBoundingClientRect if available#420
Fallback to unstable_getBoundingClientRect if available#420axyz wants to merge 1 commit intofacebook:mainfrom
Conversation
|
Hi @axyz! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
2 similar comments
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Let's bump the peer dependency instead - there are a few other things that require 0.82 now |
|
closed in favor of #421 |
This was recently changed as part of the refactoring of 74562f4#diff-bcc5857af5fe29c6679b5afaf39db7eed5fc74a15ab118691ee8c13c5954b70eL75
this implicitly binds react-strict-dom to require at least react-native 0.82.
Is that intentional?
Is there a place where the minimum required version is explicitly listed?
In that case, then maybe was just forgotten to update the peer dependency here: https://github.com/facebook/react-strict-dom/blob/main/packages/react-strict-dom/package.json#L62
Feel free to close in case, and treat this PR as a small question with a code snippet