fix: remove fontScale from CSS relative units to prevent double scaling#447
Open
axyz wants to merge 1 commit intofacebook:mainfrom
Open
fix: remove fontScale from CSS relative units to prevent double scaling#447axyz wants to merge 1 commit intofacebook:mainfrom
axyz wants to merge 1 commit intofacebook:mainfrom
Conversation
axyz
commented
Jan 28, 2026
| "height": -100, | ||
| "position": "static", | ||
| "width": NaN, | ||
| "width": 100, |
Author
There was a problem hiding this comment.
it seems that removing the fontScale accidentally fixed this preexisting bug where the resolved value was NAN, I'm assuming it could have been a lack of mocking in the test though?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default react-native textual elements have the
allowFontScalingprop set to true, effectively makingpxvalues to behave likerem/emvalues. The existing polyfill, though, scales the px values using the detectedfontScale. This leads to a double amount of scaling on the native app.This PR remove the fontScale multiplier, leaving the scaling to the native capability, while keeping the polyfill logic to translate em/rem to appropriate px values.