Skip to content

Conversation

@Nietzsche-Ubermensch
Copy link

Summary

How did you test this change?

Delete 169 outdated test fixtures from babel-plugin-react-compiler that tested deprecated error cases, TODOs, and behaviors now resolved or migrated (e.g., effect-derived-computations, preserve-memo-validation, propagate-scope-deps-hir-fork, reduce-reactive-deps).
@meta-cla
Copy link

meta-cla bot commented Dec 17, 2025

Hi @Lolavice9019!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@josephsavona
Copy link
Member

The issue with a PR like this is that there’s no easy way to verify that it does what it says - especially since there is no PR description. How did you determine what fixtures are obsolete? How can we verify you only deleted those? We get tons of spam PRs and sadly can’t trust people at their word.

The better way to do this would be to write a script that identifies and optionally deletes duplicates, which we could review, land, and then run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants