Skip to content

Conversation

@adamretter
Copy link
Contributor

@adamretter adamretter commented Dec 14, 2023

  • Fixed problems with existing JavaDoc.
  • Added missing JavaDoc.
  • Make JavaDoc warnings report as an error.
  • Add a CI job to ensure that JavaDoc is always present and correct in future.

In total this resolves over 400 JavaDoc warnings/errors.

@adamretter adamretter force-pushed the eb/cleanup-native-handle branch 2 times, most recently from 71c80cc to 0efb705 Compare December 21, 2023 20:53
@adamretter adamretter marked this pull request as ready for review December 21, 2023 20:56
@adamretter adamretter force-pushed the eb/cleanup-native-handle branch 8 times, most recently from 80632b6 to ea76e36 Compare December 21, 2023 23:39
@adamretter adamretter force-pushed the eb/cleanup-native-handle branch from ea76e36 to 3f75252 Compare January 10, 2024 11:53
@adamretter adamretter force-pushed the eb/cleanup-native-handle branch from 3f75252 to 7eae866 Compare February 6, 2024 23:37
@ajkr
Copy link
Contributor

ajkr commented Feb 20, 2024

src/main/java/org/rocksdb/util/StdErrLogger.java:15: error: StdErrLogger is not abstract and does not override abstract method getNativeHandle() in LoggerInterface
public class StdErrLogger extends RocksObject implements LoggerInterface {
       ^
src/main/java/org/rocksdb/RocksDB.java:3945: warning: [deprecation] OUT_OF_BOUNDS in PerfLevel has been deprecated
    } else if (level == PerfLevel.OUT_OF_BOUNDS) {
                                 ^
1 error
1 warning

(https://github.com/facebook/rocksdb/actions/runs/7807589234/job/21296253965?pr=12149)

@adamretter adamretter force-pushed the eb/cleanup-native-handle branch from 7eae866 to 441207d Compare January 27, 2026 13:14
@adamretter adamretter force-pushed the eb/cleanup-native-handle branch from 441207d to b542018 Compare January 27, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants