Skip to content

Conversation

@mike-evolved
Copy link

@mike-evolved mike-evolved commented Dec 2, 2025

Updates the RocksJava build system to support newer GCC compilers (versions 11 and 12) and fixes some cross-platform build issues.

Main changes:

  • Docker build script detects and uses devtoolset 9-12 (newer GCC versions), not just the old ones
  • Makefile adds variables so users can customize which Docker images to use for builds
  • PowerPC builds target Power8 as the minimum CPU for better compatibility, and won't fail if platform detection doesn't work
  • s390x builds switched from Ubuntu 18 to CentOS 7 to match other platforms

@meta-cla
Copy link

meta-cla bot commented Dec 2, 2025

Hi @mike-evolved!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Dec 2, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 2, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@mike-evolved mike-evolved changed the title Update docker-build-linux for devtoolset 11+ Update RocksDB for devtoolset 11+ Dec 4, 2025
@mike-evolved mike-evolved reopened this Dec 4, 2025
@mike-evolved mike-evolved marked this pull request as draft December 4, 2025 16:49
@mike-evolved mike-evolved force-pushed the eb/feature/docker-build-for-GCC11+ branch from dccfecb to 29d1105 Compare December 8, 2025 14:29
@adamretter adamretter force-pushed the eb/feature/docker-build-for-GCC11+ branch from 6956b37 to 28ffea0 Compare January 27, 2026 13:34
@mike-evolved mike-evolved marked this pull request as ready for review January 27, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant