C rocksdb_create_column_family(_with_ttl): Fix leak on error #14214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these functions returned an error and a non-NULL pointer when there is an error. Most users of this API are unlikely to free the pointer on error, causing a very minor memory leak. Fix these functions to delete the allocated C struct when returning an error. Extend the C API test to cover these cases.
evanj
added a commit
to evanj/rust-rocksdb
that referenced
this pull request
Jan 4, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
aleksuss
pushed a commit
to rust-rocksdb/rust-rocksdb
that referenced
this pull request
Jan 5, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
zaidoon1
pushed a commit
to zaidoon1/rust-rocksdb
that referenced
this pull request
Jan 6, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
zaidoon1
pushed a commit
to zaidoon1/rust-rocksdb
that referenced
this pull request
Jan 6, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
zaidoon1
pushed a commit
to zaidoon1/rust-rocksdb
that referenced
this pull request
Jan 6, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
zaidoon1
pushed a commit
to zaidoon1/rust-rocksdb
that referenced
this pull request
Jan 6, 2026
When rocksdb_create_column_family returns an error, it also returns a non-NULL pointer that needs to be freed. I have attempted to submit a fix for this upstream to RocksDB [1]. Add a check to free it if it returns a non-NULL pointer, which will work with older versions of RocksDB. I believe this is the last of my set of fixes for valgrind reported memory leaks in the rust-rocksdb tests. [1] facebook/rocksdb#14214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, these functions returned an error and a non-NULL pointer when there is an error. Most users of this API are unlikely to free the pointer on error, causing a very minor memory leak.
Fix these functions to delete the allocated C struct when returning an error. Extend the C API test to cover these cases.