Skip to content

Conversation

@JingYanchao
Copy link

When integrating RocksDB, I wanted to use only the SSTable data structure. During this process, I had a need for lookups and wanted to use a Bloom filter for filtering. The table_reader already provides a Get interface, but it's not exposed as a public method in sst_file_reader. I've created an interface to expose this functionality.

@meta-cla
Copy link

meta-cla bot commented Jan 16, 2026

Hi @JingYanchao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Jan 16, 2026
optimize code

optimize code
@JingYanchao JingYanchao force-pushed the johnjing/add-get-for-sst-reader branch from d617b22 to 9214bd9 Compare January 16, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant