Skip to content

Work around GCC 12 false positive warning for string::insert #14265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mszeszko-meta wants to merge 1 commit into from
+9 −5
Closed

Work around GCC 12 false positive warning for string::insert #14265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions table/unique_id.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,16 @@ Status GetUniqueIdFromTableProperties(const TableProperties &props,
}

std::string UniqueIdToHumanString(const std::string &id) {
// Not so efficient, but that's OK
std::string str = Slice(id).ToString(/*hex*/ true);
for (size_t i = 16; i < str.size(); i += 17) {
str.insert(i, "-");
std::string hex = Slice(id).ToString(/*hex*/ true);
std::string result;
result.reserve(hex.size() + hex.size() / 16);
for (size_t i = 0; i < hex.size(); i++) {
if (i > 0 && i % 16 == 0) {
result.push_back('-');
}
result.push_back(hex[i]);
}
return str;
return result;
}

std::string InternalUniqueIdToHumanString(UniqueIdPtr in) {
Expand Down
Loading