Remove compression support #14266
Open
Remove compression support #14266
+54
−512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Compression is unused in production, making this dead code that adds unnecessary complexity. Core changes: - Remove `compression` field from `BlobDBOptions` - Remove compression/decompression methods (`GetCompressedSlice`, `DecompressSlice`, `BlobDecompressor`) - Simplify `ReadBlobFromOldFile` and `GetBlobValue` to handle only uncompressed blobs - Update compaction filter to skip compression/decompression CLI tool cleanup: - Remove `--blob_db_compression_type` flag from db_bench (Stacked BlobDB) - Remove `--show_uncompressed_blob` from blob_dump tool - Remove `--dump_uncompressed_blobs` from ldb dump/file_dump commands - blob_dump_tool now fails fast with NotSupported for compressed files Tests: - Remove compression-related tests (`Compression`, `DecompressAfterReopen`, `EnableDisableCompressionGC`, `ChangeCompressionGC`) Reviewed By: xingbowang Differential Revision: D91088957
|
@mszeszko-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91088957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Compression is unused in production, making this dead code that adds unnecessary complexity.
Core changes:
compressionfield fromBlobDBOptionsGetCompressedSlice,DecompressSlice,BlobDecompressor)ReadBlobFromOldFileandGetBlobValueto handle onlyuncompressed blobs
CLI tool cleanup:
--blob_db_compression_typeflag from db_bench (Stacked BlobDB)--show_uncompressed_blobfrom blob_dump tool--dump_uncompressed_blobsfrom ldb dump/file_dump commandsTests:
Compression,DecompressAfterReopen,EnableDisableCompressionGC,ChangeCompressionGC)Reviewed By: xingbowang
Differential Revision: D91088957