[Legacy BlobDB] Remove FIFO eviction support #14268
Closed
+25
−444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mszeszko-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91088968. |
Summary: FIFO eviction is unused in production, making this dead code that adds complexity. Core changes: - Remove `is_fifo` from `BlobDBOptions` - Remove `CheckSizeAndEvictBlobFiles` and related methods - Remove `fifo_eviction_seq` and `evict_expiration_up_to` from `BlobCompactionContext` CLI tool cleanup: - Remove `--blob_db_is_fifo` flag from db_bench - Remove stale FIFO eviction comments Tests: - Remove FIFO-related tests (`FIFOEviction_*`, `FilterForFIFOEviction`) Note: TTL-based expiration (`EvictExpiredFiles`) is preserved as it handles blob file cleanup based on TTL, which is separate from FIFO eviction. Reviewed By: xingbowang Differential Revision: D91088968
mszeszko-meta
force-pushed
the
export-D91088968
branch
from
b3cc674 to
b0b9003
Compare
|
This pull request has been merged in 80f3d86. |
mszeszko-meta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core changes:
is_fifofromBlobDBOptionsCheckSizeAndEvictBlobFilesand related methodsfifo_eviction_seqandevict_expiration_up_tofromBlobCompactionContextCLI tool cleanup:
--blob_db_is_fifoflag from db_benchTests:
FIFOEviction_*,FilterForFIFOEviction)Note: TTL-based expiration (
EvictExpiredFiles) is preserved as it handles blob file cleanup based on TTL, which is separate from FIFO eviction.Reviewed By: xingbowang
Differential Revision: D91088968