Fix compilation against musl lib C #7875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a way for me to verify that? |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
Good point @jay-zhuang! I will try and get a CircleCI setup which covers building with musl. |
Contributor
Author
|
@jay-zhuang I have a CircleCI job now that tests building with musl. But you can see the output from trying to build (before this patch) with musl - https://app.circleci.com/pipelines/github/facebook/rocksdb/5557/workflows/90e82fca-ff41-4085-b3d2-5e66fc644581/jobs/85799 |
Contributor
|
@jay-zhuang merged this pull request in d5f5d65. |
ltamasi
pushed a commit
that referenced
this pull request
Jan 21, 2021
Summary: See percona/PerconaFT#450 Pull Request resolved: #7875 Reviewed By: ajkr Differential Revision: D25938020 Pulled By: jay-zhuang fbshipit-source-id: 9014dbc7b23bf92c5e63bfbdda4565bb0d2f2b58
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: See percona/PerconaFT#450 Pull Request resolved: facebook#7875 Reviewed By: ajkr Differential Revision: D25938020 Pulled By: jay-zhuang fbshipit-source-id: 9014dbc7b23bf92c5e63bfbdda4565bb0d2f2b58
jay-zhuang
pushed a commit
that referenced
this pull request
Mar 30, 2021
Summary: See percona/PerconaFT#450 Pull Request resolved: #7875 Reviewed By: ajkr Differential Revision: D25938020 Pulled By: jay-zhuang fbshipit-source-id: 9014dbc7b23bf92c5e63bfbdda4565bb0d2f2b58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See percona/PerconaFT#450